Jira (PUP-6562) Limit transaction.failed_dependencies? verbosity

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper commented on PUP-6562   Re: Limit transaction.failed_dependencies? verbosity I think ideally we wouldn't report that an ancestor dependency failed multiple times. To illustrate the problem: exec { ['exec1', 'exec2', 'exec3', 'exec4', 'exec5']: command => '/usr/bin/false' } -> notify { ['notify1', 'notify2', 'notify3']: } Produces 5x3 "Dependency <name> has failures: true" messages. $ bx puppet apply manifest.pp Notice: Compiled catalog for localhost in environment production in 0.09 seconds Error: '/usr/bin/false' returned 1 instead of one of [0] Error: /Stage[main]/Main/Exec[exec1]/returns: change from 'notrun' to ['0'] failed: '/usr/bin/false' returned 1 instead of one of [0] Error: '/usr/bin/false' returned 1 instead of one of [0] Error: /Stage[main]/Main/Exec[exec2]/returns: change from 'notrun' to ['0'] failed: '/usr/bin/false' returned 1 instead of one of [0] Error: '/usr/bin/false' returned 1 instead of one of [0] Error: /Stage[main]/Main/Exec[exec3]/returns: change from 'notrun' to ['0'] failed: '/usr/bin/false' returned 1 instead of one of [0] Error: '/usr/bin/false' returned 1 instead of one of [0] Error: /Stage[main]/Main/Exec[exec4]/returns: change from 'notrun' to ['0'] failed: '/usr/bin/false' returned 1 instead of one of [0] Error: '/usr/bin/false' returned 1 instead of one of [0] Error: /Stage[main]/Main/Exec[exec5]/returns: change from 'notrun' to ['0'] failed: '/usr/bin/false' returned 1 instead of one of [0] Notice: /Stage[main]/Main/Notify[notify1]: Dependency Exec[exec1] has failures: true Notice: /Stage[main]/Main/Notify[notify1]: Dependency Exec[exec2] has failures: true Notice: /Stage[main]/Main/Notify[notify1]: Dependency Exec[exec3] has failures: true Notice: /Stage[main]/Main/Notify[notify1]: Dependency Exec[exec4] has failures: true Notice: /Stage[main]/Main/Notify[notify1]: Dependency Exec[exec5] has failures: true Warning: /Stage[main]/Main/Notify[notify1]: Skipping because of failed dependencies Notice: /Stage[main]/Main/Notify[notify2]: Dependency Exec[exec1] has failures: true Notice: /Stage[main]/Main/Notify[notify2]: Dependency Exec[exec2] has failures: true Notice: /Stage[main]/Main/Notify[notify2]: Dependency Exec[exec3] has failures: true Notice: /Stage[main]/Main/Notify[notify2]: Dependency Exec[exec4] has failures: true Notice: /Stage[main]/Main/Notify[notify2]: Dependency Exec[exec5] has failures: true Warning: /Stage[main]/Main/Notify[notify2]: Skipping because of failed dependencies Notice: /Stage[main]/Main/Notify[notify3]: Dependency Exec[exec1] has failures: true Notice: /Stage[main]/Main/Notify[notify3]: Dependency Exec[exec2] has failures: true Notice: /Stage[main]/Main/Notify[notify3]: Dependency Exec[exec3] has failures: true Notice: /Stage[main]/Main/Notify[notify3]: Dependency Exec[exec4] has failures: true Notice: /Stage[main]/Main/Notify[notify3]: Dependency Exec[exec5] has failures: true Warning: /Stage[main]/Main/Notify[notify3]: Skipping because of failed dependencies Notice: Applied catalog in 0.10 seconds I think ideally we'd just see: $ bx puppet apply manifest.pp Notice: Compiled catalog for localhost in environment production in 0.09 seconds Error: '/usr/bin/false' returned 1 instead of one of [0] Error: /Stage[main]/Main/Exec[exec1]/returns: change from 'notrun' to ['0'] failed: '/usr/bin/false' returned 1 instead of one of [0] Error: '/usr/bin/false' returned 1 instead of one of [0] Error: /Stage[main]/Main/Exec[exec2]/returns: change from 'notrun' to ['0'] failed: '/usr/bin/false' returned 1 instead of one of [0] Error: '/usr/bin/false' returned 1 instead of one of [0] Error: /Stage[main]/Main/Exec[exec3]/returns: change from 'notrun' to ['0'] failed: '/usr/bin/false' returned 1 instead of one of [0] Error: '/usr/bin/false' returned 1 instead of one of [0] Error: /Stage[main]/Main/Exec[exec4]/returns: change from 'notrun' to ['0'] failed: '/usr/bin/false' returned 1 instead of one of [0] Error: '/usr/bin/false' returned 1 instead of one of [0] Error: /Stage[main]/Main/Exec[exec5]/returns: change from 'notrun' to ['0'] failed: '/usr/bin/false' returned 1 instead of one of [0] Warning: /Stage[main]/Main/Notify[notify1]: Skipping because of 5 failed dependencies Warning: /Stage[main]/Main/Notify[notify2]: Skipping because of 5 failed dependencies Warning: /Stage[main]/Main/Notify[notify3]: Skipping because of 5 failed dependencies Notice: Applied catalog in 0.10 seconds Then if you want to see what the failed dependencies were, run with --verbose. To accomplish that we'd just need to return the number of failed dependencies in Puppet::Transaction#failed_dependencies? and log the "Dependency <name> has failures" message at info log level. Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.