Jira (PUP-3483) Systemd provider doesn't scan for changed units

[Vincent Lours (JIRA)]

Title: Message Title

Vincent Lours commented on PUP-3483   Re: Systemd provider doesn't scan for changed units Hi Jeff Silverman, As you, I use to create my own systemd unit file. But from my understanding, the 2 actions listed in your post does not required any daemon-reload. According the man documentation, the "enable" command reload the systemd configuration after creating the symlink: enable NAME... Enable one or more unit files or unit file instances, as specified on the command line. This will create a number of symlinks as encoded in the "[Install]" sections of the unit files. After the symlinks have been created, the systemd configuration is reloaded (in a way that is equivalent to daemon-reload) to ensure the changes are taken into account immediately. [...] And I've made few tests. When a new unit file is created, the systemd is adding it automatically to the config: Example of creation of new unit file sh-4.2# cat /etc/centos-release CentOS Linux release 7.5.1804 (Core) sh-4.2# ls -l /usr/lib/systemd/system/mytest.service ls: cannot access /usr/lib/systemd/system/mytest.service: No such file or directory sh-4.2# systemctl list-unit-files | grep mytest sh-4.2# vi /usr/lib/systemd/system/mytest.service sh-4.2# cat /usr/lib/systemd/system/mytest.service [Unit] Description=Test Service After=network.target   [Install] WantedBy=multi-user.target   [Service] Type=oneshot RemainAfterExit=yes KillMode=none ExecStart=/usr/bin/logger -t "test.service" "The Test service has been started" ExecStop=/usr/bin/logger -t "test.service" "The Test service has been stopped" sh-4.2# ls -l /usr/lib/systemd/system/mytest.service -rw-r--r-- 1 root root 308 Oct 23 23:01 /usr/lib/systemd/system/mytest.service sh-4.2# systemctl list-unit-files | grep mytest mytest.service disabled sh-4.2# systemctl show mytest --property=NeedDaemonReload NeedDaemonReload=no sh-4.2# systemctl start mytest sh-4.2# systemctl status mytest -l ● mytest.service - Test Service Loaded: loaded (/usr/lib/systemd/system/mytest.service; disabled; vendor preset: disabled) Active: active (exited) since Tue 2018-10-23 23:02:20 UTC; 5s ago Process: 125 ExecStart=/usr/bin/logger -t test.service The Test service has been started (code=exited, status=0/SUCCESS) Main PID: 125 (code=exited, status=0/SUCCESS)   Oct 23 23:02:20 686235598b69 systemd[1]: Starting Test Service... Oct 23 23:02:20 686235598b69 test.service[125]: The Test service has been started Oct 23 23:02:20 686235598b69 systemd[1]: Started Test Service. sh-4.2# systemctl is-enabled mytest disabled sh-4.2# systemctl enable mytest Created symlink from /etc/systemd/system/multi-user.target.wants/mytest.service to /usr/lib/systemd/system/mytest.service. sh-4.2# systemctl is-enabled mytest enabled sh-4.2# systemctl show mytest --property=NeedDaemonReload NeedDaemonReload=no sh-4.2# systemctl status mytest -l ● mytest.service - Test Service Loaded: loaded (/usr/lib/systemd/system/mytest.service; enabled; vendor preset: disabled) Active: active (exited) since Tue 2018-10-23 23:02:20 UTC; 51s ago Main PID: 125 (code=exited, status=0/SUCCESS)   Oct 23 23:02:20 686235598b69 systemd[1]: Starting Test Service... Oct 23 23:02:20 686235598b69 test.service[125]: The Test service has been started Oct 23 23:02:20 686235598b69 systemd[1]: Started Test Service. sh-4.2# systemctl restart mytest sh-4.2# systemctl status mytest -l ● mytest.service - Test Service Loaded: loaded (/usr/lib/systemd/system/mytest.service; enabled; vendor preset: disabled) Active: active (exited) since Tue 2018-10-23 23:03:26 UTC; 2s ago Process: 147 ExecStop=/usr/bin/logger -t test.service The Test service has been stopped (code=exited, status=0/SUCCESS) Process: 148 ExecStart=/usr/bin/logger -t test.service The Test service has been started (code=exited, status=0/SUCCESS) Main PID: 148 (code=exited, status=0/SUCCESS)   Oct 23 23:03:26 686235598b69 systemd[1]: Starting Test Service... Oct 23 23:03:26 686235598b69 systemd[1]: Started Test Service. Anyway, I've submitted a Pull Request to include (if required) automatic daemon-reload on start & restart actions from puppet systemd provider. That should avoid a lot of daemon-reload exec. Feel free to check the code. Cheers Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.