Jira (PUP-9297) Audit and fix locations where set_mode is called with inappropriate permissions on Windows

[Glenn Sarti (JIRA)]

Title: Message Title

Glenn Sarti created an issue   Puppet / PUP-9297 Audit and fix locations where set_mode is called with inappropriate permissions on Windows Issue Type: Bug Assignee: Unassigned Created: 2018/11/01 12:58 AM Environment: Windows 10 - 1803 Puppet 5.5.x gem Ruby 2.4 Priority: Normal Reporter: Glenn Sarti PUP-9216 was merged earlier, which sets System ACE entries to full control. This triggers a failure in pxp-agent's tasks.run_puppet.rb test, specifically here based on the stack trace. Representative job link: https://jenkins-platform.delivery.puppetlabs.net/view/puppet-agent/view/Acceptance%20Suites/view/5.5.x/view/Suite/job/platform_puppet-agent_puppet-agent-integration-suite_daily-5.5.x/232/RMM_COMPONENT_TO_TEST_NAME=pxp_agent,SLAVE_LABEL=beaker,TEST_TARGET=windows10ent-64a/ Representative failure output: Successful task expected to have no output on stderr. --- expected +++ actual @@ -1 +1,2 @@ -nil +"\e[1;33mWarning: An attempt to set mode 416 on item C:/ProgramData/PuppetLabs/puppet/cache/reports/xln2koezj7avuqx.delivery.puppetlabs.net/201810110803.yaml would result in the group, SYSTEM, to have less than Full Control rights. This attempt has been corrected to Full Control\e[0m +" — Pull Request https://github.com/puppetlabs/puppet/pull/7167 was raised to fix one place where set_mode was used, however some other testing exposed there are other places where set_mode is used to set inappropriate permissions on Windows platforms; e.g. https://github.com/puppetlabs/puppet/pull/7167#issuecomment-430682091 This issue will track the work to find all of the set_mode call sites and audit them for appropriate-ness on Windows platforms. And then raise fix PRs where needed. Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.