Jira (PUP-9303) A heredoc with interpolation containing [ ] in the expression can cause syntax error

[Henrik Lindberg (JIRA)]

Title: Message Title

Henrik Lindberg commented on PUP-9303   Re: A heredoc with interpolation containing [ ] in the _expression_ can cause syntax error We ran into issues with applying the fix in time for Puppet 6.1.0 as it was discovered that the fix was not bug compatible with the handling of text outside the margin. The specification says that whitespace up to the margin (or first non whitespace) should be removed but the implementation simply ignored those lines. The fix must do the same as it would otherwise have to wait until a major release. A new PR is now available with the bug compatible behavior. We need to decide what to do with the specification discrepancy at a major release. We should at minimum update the spec so tell users that impl in 6.y series does not comply. We then have a choice to either change the spec to what is implemented (easy fix, spec can just state that spec changed since none could rely on the specified behaviour anyway), or we can change the spec and implementation to either make it an error to have text in the margin, or to do what is currently specified. Suggest making the decision here (to save repetition and while the understanding of the issue is still fresh) and then do the ticketing for a spec and/or impl change. Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.