Jira (BOLT-1074) Local transport returns incorrect exit status

[Nick Maludy (JIRA)]

Title: Message Title

Nick Maludy created an issue   Puppet Task Runner / BOLT-1074 Local transport returns incorrect exit status Issue Type: New Feature Assignee: Unassigned Created: 2019/01/07 7:47 AM Priority: Normal Reporter: Nick Maludy When trying to examine the exit status of a local command, i noticed that the exit status being reported by bolt was not consistent with the exit status being returned from the command/script.   The simplest way to reproduce is with the following command: $ bolt command run "exit 1" --nodes local://localhost Started on localhost... Failed on localhost: The command failed with exit code 256 Failed on 1 node: local://localhost Ran on 1 node in 0.00 seconds Instead of reporting exit status of 1, it reported an exit status of 256. Doing some debugging i printed out some debug info in the local transport's lib/bolt/transports/local/shell.rb $ bolt command run "exit 1" --nodes local://localhost Started on localhost... rc = pid 3267 exit 1 rc.to_i = 256 rc.exitstatus = 1 rc.class = Process::Status Failed on localhost: The command failed with exit code 256 Failed on 1 node: local://localhost Ran on 1 node in 0.00 seconds We can see here: https://github.com/puppetlabs/bolt/blob/master/lib/bolt/transport/local/shell.rb#L22 Bolt is using `rc.to_i` to get the exit status code from the Process's result. Reading the Ruby documentation on the Process::Status object here https://ruby-doc.org/core-2.5.0/Process/Status.html it appears that `to_i` may contain data in its high bits and since POSIX statuses are only 16-bit this may lead to odd exit statuses.   Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. For more options, visit https://groups.google.com/d/optout.