Jira (HI-612) Cannot use URIs that require escaping after interpolation

Chris Roddy (JIRA) Mon, 25 Mar 2019 10:18:09 -0700

Title: Message Title

Chris Roddy created an issue

Issue Type:	Bug
Affects Versions:	HI 3.4.3
Assignee:	Unassigned
Created:	2019/03/25 10:15 AM
Priority:	Normal
Reporter:	Chris Roddy

When I provide uris, and when a value interpolated into the URI from a variable needs to be escaped in order to be a valid URI, the lookup will fail because the URI given to Ruby's URI module is invalid.

For example, assume that I set up the hiera-http backend:

hierarchy:

  - name: "my http backend"

    lookup_key: hiera_http

    options:

      output: json

      http_connect_timeout: 10

      http_read_timeout: 10

    uris:

      - "http://cmdb.example.com/hiera/appname/%{appname}"

And that $appname contains a space:

#/tmp/facts.yaml

---

appname: "Bad app name"

Then the URI will be considered invalid:

[root@master lookup]# puppet lookup --explain foo --facts /tmp/facts.yaml

Error: Could not run: bad URI(is not URI?): http://cmdb.example.com/hiera/appname/Bad app name

I think that the URI should probably be escaped just after interpolation, in expand_uris. As far as I can tell, this is the only opportunity to escape the URI:

    def expand_uris(declared_uris, lookup_invocation)

      declared_uris.map do |declared_uri|

        uri = URI(URI.escape(interpolate(declared_uri, lookup_invocation, false)))

        ResolvedLocation.new(declared_uri, uri, true)

end

end

(https://github.com/croddy/puppet/commit/561b408bf83ea70d47d6c336e3246ab64a1ea34f)

Note that this change will also break hiera-http, which assumes that it will need to escape the URI itself, and will cause it to be doubly escaped. If it seems like I've identified the problem correctly in location_resolver.rb then I expect to file a PR against that module later.

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/puppet-bugs.
For more options, visit https://groups.google.com/d/optout.

Jira (HI-612) Cannot use URIs that require escaping after interpolation

Reply via email to