Issue #3420 has been updated by Jim Pirzyk.

File naginator.rb.patch added

The previous patch did not work for host or contact templates (actually did not 
work for any other templates other than service* templates).  I have attached a 
patch that will work for all templates (that I currently use host, contact, 
service, serviceescalation).  It will also only convert the namevar back to the 
'name' string if the register parameter is set to 0 (zero).  If the register 
parameter is set to non-zero, it is like it is not set and is not a template.
----------------------------------------
Bug #3420: Nagios "name" attribute not output correctly
https://projects.puppetlabs.com/issues/3420

Author: Robin Skoglund
Status: Needs Decision
Priority: Normal
Assignee: Bruce Richardson
Category: 
Target version: queued
Keywords: 
Branch: 


I think I've stumbled upon a bug in the way Naginator outputs the Nagios "name" 
attribute.

I have the following `nagios_service` type defined in a manifest:
<pre>
nagios_service { "jmx-${name}":
  use                 => "basic-service",
  service_description => "JMX $name",
  check_command       => "check_jmx_heap_via_ssh!$name",
  register            => "0",
  target              => "/usr/local/nagios/etc/generated_services/$name.cfg"
}
</pre>

Expected output:
<pre>
define service {
    check_command                  check_jmx_heap_via_ssh!kidkalkulator
    register                       0
    name                           jmx-kidkalkulator
    service_description            JMX kidkalkulator
    use                            basic-service
}
</pre>

Actual output:
<pre>
define service {
    check_command                  check_jmx_heap_via_ssh!kidkalkulator
    register                       0
    ## --PUPPET_NAME-- (called '_naginator_name' in the manifest)               
 jmx-kidkalkulator-test
    service_description            JMX kidkalkulator
    use                            basic-service
}
</pre>

I attached a patch that changes `puppet/provider/naginator.rb` to output as 
expected, but I am not sure whether the patch will break other parts of 
Naginator/puppet.



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to