Issue #2521 has been updated by Daniel Pittman.

Nigel Kersten wrote:
> Daniel Pittman wrote:
> > Anyway, I don't think trying to work around every poorly coded daemon is a 
> > long term winner, and still want this rejected.
> 
> I don't believe we should work around every poorly coded daemon either.

...and, just to be clear, we are also of the firm opinion that manually 
touching these times is not going to break other services, like daemons that 
monitor configuration files and restart every time they change?  Not that I had 
a huge, heavy, painful Java stack that would actually do that, except it failed 
if you restarted too quickly and all. :)

> If this is a problem for a common method of interacting with the most common 
> crond (still not sure which one we're talking about in this thread) then I 
> think we can make an argument for working around those specific issues.
> 
> A reproducible case would be brilliant here.

Well, IMO the cron provider should be rewritten entirely at this point, so most 
of these issues would just vanish anyhow.  Reproduction instructions would 
certainly help convince me we should special-case this particular "special" 
daemon.
----------------------------------------
Bug #2521: file{} should update all timestamps when renaming files from temp 
file.
https://projects.puppetlabs.com/issues/2521

Author: R.I. Pienaar
Status: Needs Decision
Priority: Normal
Assignee: Nigel Kersten
Category: file
Target version: 
Affected Puppet version: 0.24.8
Keywords: 
Branch: 


At present puppet writes new files made with the file resource type using a 
temp file then renames the temp file.  Ruby rename only updates change time not 
mtime.

This is a problem when interacting with daemons that monitor directories for 
new files, like /etc/cron.d:

1) puppet creates /etc/cron.d/foo.zxxx
2) crond checks for new files matching its rules, the temp file does not match 
does not get noticed, crond saves last checked timestamp
3) puppet renames /etc/cron.d/foo.zxxx -> /etc/cron.d/foo and only ctime gets 
updated not mtime
4) crond checks for new files since last check, finds none.

I think puppet should probably touch both mtime and ctime after renaming a file.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to