Issue #6366 has been updated by James Turnbull.

Target version deleted (queued)


----------------------------------------
Bug #6366: Test harness: fix silent failures during setup
https://projects.puppetlabs.com/issues/6366

Author: Dominic Maraglia
Status: Closed
Priority: Normal
Assignee: Dominic Maraglia
Category: Harness
Target version: 
Patch: None
Keywords: 
Branch: 


During the setup phase, silent not fatal errors cause the harness to halt.  As 
an example, the ntp date function appears to run correctly, the test is logged 
as passing, including returning zero. The then halts, claiming a non-zero 
return code, no further output is seen, even in --debug mode.

I have added a work around for this in lib/setup.rb, where a non-zero return 
code simply warns and continues execution -- this is needs a proper fix.

Example silent failure:
<pre>
$ [djm puppet-acceptance (pe_ro_install_fix)]$ ./systest.rb -c 
cfg_examples/3hosts-386_rhel_cent_ubnt  --type pe_ro -t 
tests/post_install/ValidateRuby.rb --debug
Writing logs to log/2011-02-17_14:30:39/run.log

Using Config cfg_examples/3hosts-386_rhel_cent_ubnt
Found: Puppet Version 1.0
host is agent only
host is master and dashboard
host is agent only
==============================================================================
Performing test setup steps



setup/early/01-ntpdate.rb executing...
Update system time sync
  * run ntpdate against NTP pool systems
cent-55-386-1: RemoteExec(["ntpdate us.pool.ntp.org"])
<STDOUT>
17 Feb 14:30:41 ntpdate[3179]: step time server 216.45.57.38 offset 
2589827.719385 sec

</STDOUT>
<STDERR>

</STDERR>
Exited with 0

rhel-55-386-1: RemoteExec(["ntpdate us.pool.ntp.org"])
<STDOUT>
17 Feb 14:30:44 ntpdate[3214]: step time server 216.45.57.38 offset 
2589777.274601 sec

</STDOUT>
<STDERR>

</STDERR>
Exited with 0

ubnt-1004-386-1: RemoteExec(["ntpdate us.pool.ntp.org"])
<STDOUT>
17 Feb 14:30:46 ntpdate[1297]: step time server 216.45.57.38 offset 
1819872.487050 sec

</STDOUT>
<STDERR>

</STDERR>
Exited with 0

setup/early/01-ntpdate.rb passed
Warn: Setup action setup/early/01-ntpdate.rb returned non-zero
</pre>


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to