Jira (PUP-9750) optionally add pe_version to server_facts

[Thomas Kishel (JIRA)]

Title: Message Title

Thomas Kishel commented on PUP-9750   Re: optionally add pe_version to server_facts This sets server_facts['pe_version'] which sets/overrides the pe_version fact ... but only in the catalog compiled by the server: [root@pe-201818-master ~]# cat /etc/puppetlabs/code/environments/production/manifests/site.pp node default { $gpev = get_pe_version() if $gpev { notify { "PE Version ${gpev} | ${server_facts['pe_version']} | ${pe_version}": } } } [root@pe-201818-agent ~]# puppet agent -t Info: Using configured environment 'production' Info: Retrieving pluginfacts Info: Retrieving plugin Info: Retrieving locales Info: Loading facts Info: Caching catalog for pe-201818-agent.puppetdebug.vlan Info: Applying configuration version '1560459967' Notice: PE Version 2018.1.8 | 2018.1.8 | 2018.1.8 Notice: /Stage[main]/Main/Node[pe-201818-agent.puppetdebug.vlan]/Notify[PE Version 2018.1.8 | 2018.1.8 | 2018.1.8]/message: defined 'message' as 'PE Version 2018.1.8 | 2018.1.8 | 2018.1.8' Notice: Applied catalog in 0.03 seconds ... even if the puppetlabs-stdlib module is installed. Again, but only in the catalog compiled by the server: [root@pe-201818-agent ~]# facter -p | grep 2018.1.8 <crickets> Given the various fact names available on a compiling (PE) master: [root@pe-201818-master ~]# facter -p | grep 2018.1.8 pe_build => 2018.1.8 pe_server_version => 2018.1.8 And the fact names in the puppetlabs-stdlib module: is_pe pe_version pe_major_version pe_minor_version pe_patch_version And the function names in PE: pe_compiling_server_version pe_server_version We should carefully consider the name of this server_facts key in regard to simplification and backward compatibility. Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.312257.1560367030000.46722.1560460620464%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.