Jira (FACT-1930) Relax ruby facter ffi constraint for ruby 2.6

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper created an issue   Facter / FACT-1930 Relax ruby facter ffi constraint for ruby 2.6 Issue Type: Improvement Assignee: Unassigned Created: 2019/06/13 2:17 PM Priority: Normal Reporter: Josh Cooper If you try to bundle install puppet on ruby 2.6 on Windows, it will fail because the windows facter gem is constrained to: if RUBY_VERSION < '2.0.0' gem 'ffi', '<= 1.9.14', :require => false else gem 'ffi', '~> 1.9.18', :require => false end But ffi 1.9.x doesn't support ruby 2.6, as it was added in 1.10.0. We should relax facter's ffi dependency. The safest thing is to only relax the ffi dependency when running on ruby 2.6 or greater: if RUBY_VERSION.to_f < 2.0 gem 'ffi', '<= 1.9.14', :require => false elsif RUBY_VERSION.to_f < 2.6 gem 'ffi', '~> 1.9.18', :require => false else gem 'ffi', '~> 1.10.0', :require => false end /cc Ethan Brown, Mihai Buzgau Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.312360.1560460629000.46726.1560460680744%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.