Jira (PUP-9647) Pip package provider should use execute for Windows compatibility

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper commented on PUP-9647   Re: Pip package provider should use execute for Windows compatibility I think the issue occurs if pip --version returns output that doesn't match the expected regex. To repro, created pip executable shell script in current working directory: #!/bin/sh echo whoops PATH=.:$PATH bundle exec puppet apply -e "package { 'foo': provider => pip }" --trace Notice: Compiled catalog for neptune in environment production in 0.02 seconds Error: Failed to apply catalog: undefined method `[]' for nil:NilClass /Users/josh/work/puppet/lib/puppet/provider/package/pip.rb:73:in `block (2 levels) in pip_version' /Users/josh/work/puppet/lib/puppet/provider/package/pip.rb:72:in `each' /Users/josh/work/puppet/lib/puppet/provider/package/pip.rb:72:in `collect' /Users/josh/work/puppet/lib/puppet/provider/package/pip.rb:72:in `block in pip_version' /Users/josh/work/puppet/lib/puppet/util/execution.rb:81:in `block (2 levels) in execpipe' /usr/local/Cellar/rbenv/1.1.2/versions/2.3.8/lib/ruby/2.3.0/open-uri.rb:37:in `open' /usr/local/Cellar/rbenv/1.1.2/versions/2.3.8/lib/ruby/2.3.0/open-uri.rb:37:in `open' /Users/josh/work/puppet/lib/puppet/util/execution.rb:80:in `block in execpipe' /Users/josh/work/puppet/lib/puppet/util.rb:129:in `withenv' /Users/josh/work/puppet/lib/puppet/util/execution.rb:79:in `execpipe' /Users/josh/work/puppet/lib/puppet/provider.rb:117:in `execpipe' /Users/josh/work/puppet/lib/puppet/provider/package/pip.rb:71:in `pip_version' /Users/josh/work/puppet/lib/puppet/provider/package/pip.rb:35:in `instances' Since the pip provider combines stdout and stderr, it's possible something is being written to stderr. This can be simulated using: #!/bin/sh echo whoops >/dev/stderr echo pip 1.2.3 The pip provider shouldn't assume each line of output from pip --version matches the regex, see https://github.com/puppetlabs/puppet/blob/179bd10781978ac631eb13fd5b311b420e2c609c/lib/puppet/provider/package/pip.rb#L45 Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To post to this group, send email to puppet-bugs@googlegroups.com. Visit this group at https://groups.google.com/group/puppet-bugs. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.305257.1555533562000.60133.1561487160818%40Atlassian.JIRA. For more options, visit https://groups.google.com/d/optout.