Issue #5011 has been updated by Daniel Pittman.
I added a couple of comments on this in the GitHub commits, but to replicate: 1. This calculates swap total and swap once, then returns that value forever. Both are dynamic on Darwin, so we should recalculate them each time. 1. A minor nit: the fixture is small enough that we can just put it inline to the test framework. 1. A "nice to add" feature, exporting a fact about swap being encrypted. Thanks for the contribution; it looks generally excellent. ---------------------------------------- Feature #5011: Swap statistics for OSX https://projects.puppetlabs.com/issues/5011 Author: Nathan Rich Status: Ready For Testing Priority: Normal Assignee: Adrien Thebo Category: library Target version: 1.5.9 Keywords: Branch: https://github.com/adrienthebo/facter/tree/tickets/next/5011 Some kind of basic swap statistics for OSX boxes -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
