Jira (PUP-9913) described_class.has_feature leaks global state

[Josh Cooper (JIRA)]

Title: Message Title

Josh Cooper created an issue   Puppet / PUP-9913 described_class.has_feature leaks global state Issue Type: Task Assignee: Unassigned Created: 2019/07/23 3:35 PM Priority: Normal Reporter: Josh Cooper Some rspec tests stub provider features by calling: described_class.has_feature :libuser However that modifies the global provider class, which metaprograms provider feature methods, such as: Puppet::Provider::User::UseraddProvider.libuser? Puppet::Provider::User::UseraddProvider#feature?(:libuser) The tests should be updated to stub the provider class and instance instead, such as allow(described_class).to receive(:libuser?).and_return(true) Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.317847.1563921337000.28219.1563921360165%40Atlassian.JIRA.