Issue #4980 has been updated by Daniel Pittman. Status changed from Ready For Testing to Tests Insufficient
There are a few, fairly minor, issues with the tests as written; the biggest headache they have is that they might fail on Debian/Ubuntu because of the special-case result not being taken into account. The comments are inline to the commit using the github, and are not reproduced here. I also note that these are a couple of commits directly on top of the facter 'master' branch, which isn't in line with our dev process. They need to be on a separate branch off of next, and to merge in when they are done. The details are here: http://projects.puppetlabs.com/projects/puppet/wiki/Development_Development_Lifecycle Thanks very much for your great contribution to Facter; it is good to see this sort of thing getting attention. ---------------------------------------- Bug #4980: Darwin doesn't show architecture fact https://projects.puppetlabs.com/issues/4980 Author: Nathan Rich Status: Tests Insufficient Priority: Low Assignee: Michael Kincaid Category: library Target version: 1.5.9 Keywords: Branch: https://github.com/jamtur01/facter/tree/tickets/master/4980 lib/facter/architecture.rb: Facter.add(:architecture) do confine :kernel => :openbsd setcode do architecture = Facter.value(:hardwaremodel) end end change to Facter.add(:architecture) do confine :kernel => [:openbsd, :darwin] setcode do architecture = Facter.value(:hardwaremodel) end end -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
