Jira (PUP-9570) Catalog failure on first run due to pluginsync and environment switch

[Reid Vandewiele (JIRA)]

Title: Message Title

Reid Vandewiele commented on PUP-9570   Re: Catalog failure on first run due to pluginsync and environment switch Just for fun, I tried to use the example code to create a workable pluginsync_environment fact. It doesn't seem to quite work though. I created a simple site.pp with this code in it: if $facts['pluginsync_environment'] != $server_facts['environment'] { notify { 'STOP': message => "Now what? pluginsync_environment=${facts['pluginsync_environment']}, server_facts.environment=${server_facts['environment']}", } } else { notify { 'PROCEED': message => "Safe to compile catalog. pluginsync_environment=${facts['pluginsync_environment']}, server_facts.environment=${server_facts['environment']}", } } Then, I observed what happened when trying to switch from a starting environment of env_1 to a new target environment of env_2. [root@pe-xl-core-2 ~]# FACTER_custom_environment=env_1 puppet agent -t Notice: Local environment: 'production' doesn't match server specified node environment 'env_1', switching agent to 'env_1'. Info: Retrieving pluginfacts Info: Retrieving plugin Info: Retrieving locales Info: Loading facts Info: Caching catalog for pe-xl-core-2.dev36.puppet.vm Info: Applying configuration version '1569285650' Notice: Safe to compile catalog. pluginsync_environment=env_1, server_facts.environment=env_1 Notice: /Stage[main]/Main/Notify[PROCEED]/message: defined 'message' as 'Safe to compile catalog. pluginsync_environment=env_1, server_facts.environment=env_1' Notice: Applied catalog in 0.08 seconds [root@pe-xl-core-2 ~]# FACTER_custom_environment=env_2 puppet agent -t Notice: Local environment: 'production' doesn't match server specified node environment 'env_1', switching agent to 'env_1'. Info: Retrieving pluginfacts Info: Retrieving plugin Info: Retrieving locales Info: Loading facts Info: Caching catalog for pe-xl-core-2.dev36.puppet.vm Notice: Local environment: 'env_1' doesn't match server specified environment 'env_2', restarting agent run with environment 'env_2' Info: Retrieving pluginfacts Info: Retrieving plugin Notice: /File[/opt/puppetlabs/puppet/cache/lib/facter/env_1.rb]/ensure: removed Notice: /File[/opt/puppetlabs/puppet/cache/lib/facter/env_2.rb]/ensure: defined content as '{md5}d41d8cd98f00b204e9800998ecf8427e' Info: Retrieving locales Info: Loading facts Info: Caching catalog for pe-xl-core-2.dev36.puppet.vm Info: Applying configuration version '1569285712' Notice: Now what? pluginsync_environment=env_1, server_facts.environment=env_2 Notice: /Stage[main]/Main/Notify[STOP]/message: defined 'message' as 'Now what? pluginsync_environment=env_1, server_facts.environment=env_2' Notice: Applied catalog in 0.09 seconds [root@pe-xl-core-2 ~]# FACTER_custom_environment=env_2 puppet agent -t Notice: Local environment: 'production' doesn't match server specified node environment 'env_2', switching agent to 'env_2'. Info: Retrieving pluginfacts Info: Retrieving plugin Info: Retrieving locales Info: Loading facts Info: Caching catalog for pe-xl-core-2.dev36.puppet.vm Info: Applying configuration version '1569285712' Notice: Safe to compile catalog. pluginsync_environment=env_2, server_facts.environment=env_2 Notice: /Stage[main]/Main/Notify[PROCEED]/message: defined 'message' as 'Safe to compile catalog. pluginsync_environment=env_2, server_facts.environment=env_2' Notice: Applied catalog in 0.08 seconds [root@pe-xl-core-2 ~]# The problem seems to be that on the catalog retry, the fact's value is already set and does not get re-evaluated. So even though the Puppet agent performed a second pluginsync against the correct new environment, this is not reflected in the value of the pluginsync_fact. This avoids the problem of failing to compile a catalog, but doesn't achieve the desired end result of finishing a full, real Puppet run in the new target environment. Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.300842.1553021716000.110754.1569286080638%40Atlassian.JIRA.