Jira (PUP-5915) exec resources fail unless cwd is readable

James Ralston (JIRA) Tue, 08 Oct 2019 13:34:16 -0700

Title: Message Title

I was incorrect. This is not actually fixed.

The problem is that the exec resource itself implicitly defaults the cwd parameter to the cwd if the cwd parameter was not provided for the exec resource in question.

In the case where Puppet's cwd is inaccessible, this will cause all Puppet exec() resources to fail.

I assert that defaulting the cwd parameter to the cwd of the Puppet process is wrong. If the user does not supply a cwd parameter to the exec resource in question, Puppet must assume that the user does not want Puppet to attempt to chdir() to any directory. Assuming that the user wants Puppet to chdir() to the cwd is an erroneous assumption, as 1) this is not what the user specified, and 2) it's nonsensical, as even if the chdir() call succeeds, Puppet has not actually changed the cwd.

To fully fix this bug, I agree with John Bollinger in PUP-10080: the "implicitly default the cwd parameter to Puppet's cwd if it was not specified" behavior is wrong and should be removed.

I think the only thing required is removing this line from lib/puppet/provider/exec.rb:

      cwd ||= Dir.pwd

This is because, from my read, Puppet::Util::Execution.execute() will do the correct thing if the cwd parameter is unspecified:

    cwd = options[:cwd]

    if cwd && ! Puppet::FileSystem.directory?(cwd)

      raise ArgumentError, _("Working directory %{cwd} does not exist!") % { cwd: cwd }

end

And:

        cwd = options[:cwd]

        Dir.chdir(cwd) if cwd

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.117135.1455734657000.134898.1570566840307%40Atlassian.JIRA.

Jira (PUP-5915) exec resources fail unless cwd is readable

Reply via email to