Issue #6711 has been updated by Nigel Kersten. Status changed from Needs Decision to Accepted Assignee deleted (Nigel Kersten)
I think I'm to blame for the initial "tries" code anyway.... :) I'd never used the refresh attribute when I wrote that, so it's not surprising I forgot about it. I'm not actually sure I'm in favor of it or not when I think about it. Why do we need it when you can make an exec "refreshonly" ? If we're keeping the feature, we should make it work the same way with "tries" as the original command. ---------------------------------------- Bug #6711: exec type refresh cmd should do tries and log https://projects.puppetlabs.com/issues/6711 Author: Matt Robinson Status: Accepted Priority: Normal Assignee: Category: Target version: Affected Puppet version: development Keywords: Branch: # Run the command, or optionally run a separately-specified command. def refresh if self.check_all_attributes(true) if cmd = self[:refresh] provider.run(cmd) else self.property(:returns).sync end end end If a refresh parameter is given to an exec type with tries set exec { '/some/cmd' : refresh => '/some/othercmd', tries => 10, } tries will only apply to the /some/cmd, and not to the /some/othercmd when the exec resource is triggered by a refresh. This is probably unintuitive and should be fixed or at least documented. Also, by having different code paths for running the command regularly and through a refresh some logging gets lost when refreshing. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
