Issue #6616 has been updated by James Turnbull.

Status changed from Accepted to Ready For Testing
Branch set to https://github.com/jamtur01/facter/tree/tickets/master/6616


----------------------------------------
Bug #6616: Facter virtual tests failing when `/usr/lib/vmware/bin/vmware-vmx` 
exists on system
https://projects.puppetlabs.com/issues/6616

Author: Jacob Helwig
Status: Ready For Testing
Priority: Normal
Assignee: 
Category: testing
Target version: 1.5.9
Keywords: 
Branch: https://github.com/jamtur01/facter/tree/tickets/master/6616


Bisecting reveals that these failing tests were introduced in 
commit:739040f234c356133e2cb72318f687e8c0e56b9b


    % spec -f n spec/unit/virtual.rb
    Virtual fact
      should be zone on Solaris when a zone
      should be jail on FreeBSD when a jail in kvm
      should be hpvm on HP-UX when in HP-VM
      on Darwin
        should be parallels with Parallels vendor id
        should be parallels with Parallels vendor name
        should be vmware with VMWare vendor id
        should be vmware with VMWare vendor name
      on Linux
        should be parallels with Parallels vendor id from lspci (FAILED - 1)
        should be parallels with Parallels vendor name from lspci (FAILED - 2)
        should be vmware with VMware vendor name from lspci (FAILED - 3)
        should be vmware with VMWare vendor name from dmidecode (FAILED - 4)
        should be parallels with Parallels vendor name from dmidecode (FAILED - 
5)
        should be vmware with VMWare vendor name from prtdiag (FAILED - 6)
        should be parallels with Parallels vendor name from prtdiag (FAILED - 7)
    is_virtual fact
      should be virtual when running on xen
      should be false when running on xen0
      should be true when running on vmware
      should be true when running on openvz
      should be true when running on kvm
      should be true when running in jail
      should be true when running in zone
      should be true when running on hp-vm
      should be true when running on parallels
    
    1)
    'Virtual fact on Linux should be parallels with Parallels vendor id from 
lspci' FAILED
    expected: "parallels",
         got: "vmware_server" (using ==)
    ./spec/unit/virtual.rb:72:
    
    2)
    'Virtual fact on Linux should be parallels with Parallels vendor name from 
lspci' FAILED
    expected: "parallels",
         got: "vmware_server" (using ==)
    ./spec/unit/virtual.rb:78:
    
    3)
    'Virtual fact on Linux should be vmware with VMware vendor name from lspci' 
FAILED
    expected: "vmware",
         got: "vmware_server" (using ==)
    ./spec/unit/virtual.rb:84:
    
    4)
    'Virtual fact on Linux should be vmware with VMWare vendor name from 
dmidecode' FAILED
    expected: "vmware",
         got: "vmware_server" (using ==)
    ./spec/unit/virtual.rb:91:
    
    5)
    'Virtual fact on Linux should be parallels with Parallels vendor name from 
dmidecode' FAILED
    expected: "parallels",
         got: "vmware_server" (using ==)
    ./spec/unit/virtual.rb:98:
    
    6)
    'Virtual fact on Linux should be vmware with VMWare vendor name from 
prtdiag' FAILED
    expected: "vmware",
         got: "vmware_server" (using ==)
    ./spec/unit/virtual.rb:106:
    
    7)
    'Virtual fact on Linux should be parallels with Parallels vendor name from 
prtdiag' FAILED
    expected: "parallels",
         got: "vmware_server" (using ==)
    ./spec/unit/virtual.rb:114:
    
    Finished in 0.084444 seconds
    
    23 examples, 7 failures

This appears to be due to insufficient stubbing.

    % ls -l /usr/lib/vmware/bin/vmware-vmx
    -rwsr-xr-x 1 root root 9813400 2010-10-31 20:34 
/usr/lib/vmware/bin/vmware-vmx



-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to