Jira (PUP-10097) Protect against binary diffs

Josh Cooper (JIRA) Fri, 01 Nov 2019 14:42:16 -0700

Title: Message Title

Josh Cooper commented on

Puppet shells out to the diff executable, and it's implementation specific how it handles diff'ing binary content. In this case, the bytes in the file are classified as:

 file /tmp/test

/tmp/test: Non-ISO extended-ASCII text, with no line terminator

Which comes from https://github.com/file/file/blob/954da3a0fb8046e22c6fb74734b39eec79deea1e/src/encoding.c#L142-L146. The only time it considers the file to be binary is if the file contains a character known to never appear in text (like some control chars or 0x7F) https://github.com/file/file/blob/954da3a0fb8046e22c6fb74734b39eec79deea1e/src/encoding.c#L230-L250.

A better approach is probably to use the diff-lcs gem, to detect binary content more gracefully, which would also eliminate issues with diff compatibility across platforms and the lack of diff on windows. I think there's already a ticket filed on that.

Add Comment

This message was sent by Atlassian JIRA

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.328673.1570644934000.17270.1572644520273%40Atlassian.JIRA.

Jira (PUP-10097) Protect against binary diffs

Reply via email to