Jira (PUP-10150) Puppet Stack Trace is cleared before exception handlers can query it

[Glenn Sarti (JIRA)]

Title: Message Title

Glenn Sarti created an issue   Puppet / PUP-10150 Puppet Stack Trace is cleared before exception handlers can query it Issue Type: Bug Assignee: Unassigned Created: 2019/11/21 6:01 AM Priority: Normal Reporter: Glenn Sarti Puppet Version: 6.11.1 Puppet Server Version: N/A OS Name/Version: Windows 10 As part of https://github.com/puppetlabs/puppet/pull/7754 the Puppet Stack Trace feature was modified to use an independent stack trace storing mechanism, however this may have introduced an unforseen behaviour change. Previously users would be able to trace how Puppet has traversed the invocations within a Manifest file. For example int the given manifest class nest1 { fail('somethinng') }   class nest2 { include nest1 }   include nest2 Previously in Puppet 6.10.1, we can see a puppet apply <manifest> --trace gives Error: Evaluation Error: Error while evaluating a Function Call, somethinng (file: C:/Source/puppet/tmp/test.pp, line: 2, column: 3) on node glenn.sarti-r90qu2hx C:/Source/puppet/lib/puppet/parser/functions/fail.rb:10:in `block in get_binding' C:/Source/puppet/lib/puppet/parser/functions.rb:206:in `block (2 levels) in newfunction' ... C:/Source/puppet/tmp/test.pp:2:in `block in call_function' ... C:/Source/puppet/tmp/test.pp:6:in `block in call_function' ... C:/Source/puppet/tmp/test.pp:9:in `block in call_function' ... C:/Source/puppet/tmp/test.pp:in `stack' ... We can see the various includes and Puppet call stack. However in Puppet 6.11.1 we get: ... Error: Evaluation Error: Error while evaluating a Function Call, somethinng (file: C:/Source/puppet/tmp/test.pp, line: 2, column: 3) on node glenn.sarti-r90qu2hx And that's it. The call stack within Puppet is no longer available. Now, that's probably due to Puppet no longer using the Ruby stack to store the information, however... Due to the way the stack is implemented, the stack is cleared (via the `shift` in https://github.com/puppetlabs/puppet/blob/1356f58d66/lib/puppet/pops/puppet_stack.rb#L44-L46) BEFORE any error trapping can occur. Effectively, the Puppet Stack is no longer available during exceptions, only the exception location, which seems a concerning. Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.336155.1574344871000.41636.1574344920277%40Atlassian.JIRA.