Issue #4576 has been updated by Daniel Pittman.

Status changed from Accepted to Code Insufficient

Two bits of feedback, one relevant and one irrelevant:

The relevant one is that your commit doesn't implement what this discussed, but 
rather works around the problem.  The correct behaviour is that we should be 
failing the compilation when a non-existent class is referenced here, not just 
logging something on the server.

The less relevant one, right now, is that the commit message needs a bit of 
polish on the language.  It isn't all that clear what the subject and object of 
the text are as you wander though, which made it a bit more confusing to match 
it with your code changes.

----------------------------------------
Bug #4576: nonexistent classes specified in external node definition are ignored
https://projects.puppetlabs.com/issues/4576

Author: martin krafft
Status: Code Insufficient
Priority: High
Assignee: Dan Bode
Category: 
Target version: 2.6.x
Affected Puppet version: 0.25.5
Keywords: 
Branch: https://github.com/bodepd/puppet/tree/feature/2.6.next/4576


If the external node classifier outputs classes that are not defined, puppetd 
does nothing. It should really die.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to