Jira (PUP-10222) Puppet lookup invocation recursion detection not thread-safe

[Maggie Dreyer (JIRA)]

Title: Message Title

Maggie Dreyer created an issue   Puppet / PUP-10222 Puppet lookup invocation recursion detection not thread-safe Issue Type: Bug Assignee: Unassigned Created: 2020/01/07 10:38 AM Priority: Normal Reporter: Maggie Dreyer Initial production testing with Puppet in multithreaded mode has revealed that the code to detect recursive hiera lookups is not thread-safe: 2020-01-07T08:41:31.500-08:00 ERROR [qtp612319309-15848] [puppetserver] Puppet Evaluation Error: Error while evaluating a Resource Statement, Lookup of key 'ntp::config_template' failed: Recursive lookup detected in [epel::epel_debuginfo_sslclientkey, ntp::tinker, ntp::leapfile, ntp::config_template] (file: /etc/puppetlabs/code/environments/production/site/profile/manifests/time.pp, line: 2, column: 3) on node ldap-testfixture-prod-2.delivery.puppetlabs.net These errors come from https://github.com/puppetlabs/puppet/blob/master/lib/puppet/pops/lookup/invocation.rb#L84. Current theory is that since the @name_stack class variable is not thread-safe, if multiple threads look for the same key at the same time, this error could occur. Add Comment   This message was sent by Atlassian JIRA (v7.7.1#77002-sha1:e75ca93) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.341337.1578422330000.14909.1578422340455%40Atlassian.JIRA.