Issue #6679 has been updated by James Goddard.
I have no problem if the consensus is to leave the redhat designation. However, it feels incorrect to me. It seems to me that if a distro requires a separate set of repos and contains different packages, it should have its own designation. Thanks, Jim Goddard On Mar 19, 2011 12:30 AM, <[email protected]> wrote: > > Issue #6679 has been updated by Alessandro Franceschi. > Status changed from Closed to Re-opened > > I just updated Facter from 1.5.8 to 1.5.9 on a Scientific Linux 6 test box and found that the operatingsystem fact changed from RedHat (yes, it was not null on my test machine) to Scientific. This practically breaks every existing module where the operatingsystem fact is used. I don’t think that’s a good idea. Consider that Sl is gaining popularity for the delays of Centos 6 , it might deserve a dedicated operatingsystem fact name but at the same time “RedHat” worked fine. > > I reopen the ticket just to have confirmation that the final choice on its operatingsystem fact value is “Scientific” (which actually doesn’t seem complete) so that I’ve to correct all my modules only once. > > Best regards, Alessandro Franceschi > > ________________________________ > Bug #6679: Facter 1.5.8 does not identify Scientific Linux > Author: James Goddard > Status: Re-opened > Priority: Low > Assignee: > Category: library > Target version: 1.5.9 > Keywords: operatingsystem > Branch: https://github.com/jamtur01/facter/tree/ticket/master/6679 > > I just started playing with Scientific Linux 6.0, and the first thing I have noticed is that the operatingsystem fact has no flag for this distro. The relevant file is /usr/lib/ruby/site_ruby/1.8/facter/operatingsystem.rb, and as a first draft, I have added a clause for it (and attached): > > 39,40d38 < elsif txt =~ /scientific/i < “Scientific” > > Thanks, > > Jim Goddard > > ________________________________ > > You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account ---------------------------------------- Bug #6679: Facter 1.5.8 does not identify Scientific Linux https://projects.puppetlabs.com/issues/6679 Author: James Goddard Status: Re-opened Priority: Low Assignee: Category: library Target version: 1.5.9 Keywords: operatingsystem Branch: https://github.com/jamtur01/facter/tree/ticket/master/6679 I just started playing with Scientific Linux 6.0, and the first thing I have noticed is that the operatingsystem fact has no flag for this distro. The relevant file is /usr/lib/ruby/site_ruby/1.8/facter/operatingsystem.rb, and as a first draft, I have added a clause for it (and attached): 39,40d38 < elsif txt =~ /scientific/i < "Scientific" Thanks, Jim Goddard -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
