Jira (PUP-10363) server_list is processed once per service not once per session

[Josh Cooper (Jira)]

Title: Message Title

Josh Cooper commented on PUP-10363   Re: server_list is processed once per service not once per session This passes CI but is totally broken: $ bx puppet agent -t --server_list woeful-romantic.delivery.puppetlabs.net Info: Using configured environment 'production' Info: Retrieving pluginfacts Error: /File[/Users/josh/.puppetlabs/opt/puppet/cache/facts.d]: Failed to generate additional resources using 'eval_generate': undefined method `get_file_metadatas' for #<Puppet::HTTP::Service::Compiler:0x00007ffad72a6de8> Error: /File[/Users/josh/.puppetlabs/opt/puppet/cache/facts.d]: Could not evaluate: Could not retrieve file metadata for puppet:///pluginfacts: undefined method `get_file_metadata' for #<Puppet::HTTP::Service::Compiler:0x00007ffad72a6de8> Info: Retrieving plugin Error: /File[/Users/josh/.puppetlabs/opt/puppet/cache/lib]: Failed to generate additional resources using 'eval_generate': undefined method `get_file_metadatas' for #<Puppet::HTTP::Service::Compiler:0x00007ffad72a6de8> Error: /File[/Users/josh/.puppetlabs/opt/puppet/cache/lib]: Could not evaluate: Could not retrieve file metadata for puppet:///plugins: undefined method `get_file_metadata' for #<Puppet::HTTP::Service::Compiler:0x00007ffad72a6de8> Info: Retrieving locales Error: /File[/Users/josh/.puppetlabs/opt/puppet/cache/locales]: Failed to generate additional resources using 'eval_generate': undefined method `get_file_metadatas' for #<Puppet::HTTP::Service::Compiler:0x00007ffad72a6de8> Error: /File[/Users/josh/.puppetlabs/opt/puppet/cache/locales]: Could not evaluate: Could not retrieve file metadata for puppet:///locales: undefined method `get_file_metadata' for #<Puppet::HTTP::Service::Compiler:0x00007ffad72a6de8> Info: Caching catalog for XXX.puppet.net Info: Applying configuration version '1583980590' Notice: Applied catalog in 0.01 seconds Error: Could not send report: undefined method `put_report' for #<Puppet::HTTP::Service::Compiler:0x00007ffad72a6de8> The problem is the server list resolver caches the first *service* that we resolved, not the host & port, so since we first resolve server_list for the node request, we end up caching the "compiler" service and using that for fileserver, report, etc. Add Comment   This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.349115.1583791822000.10864.1583980740113%40Atlassian.JIRA.