Issue #2782 has been updated by Matt Robinson. Status changed from Code Insufficient to Ready For Testing Branch changed from http://github.com/hoanga/puppet/tree/0.25.x_1.9.1 to https://github.com/mmrobins/puppet/tree/19_fixes
I only got so far as using Al's solution for dealing with const_defined? problems. The branch is too old to merge in at all easily since 0.25.x was never really merged into 2.6.x or later, so it's hard to tell about the other changes, but I haven't run into problems to motivate making them yet. I'm attaching a branch that gets the code to a point that the tests will run, so past all the syntax errors that prevent code from even loading. Plenty of tests still fail under Ruby 1.9, but none do under 1.8.7. The branch needs some cleanup of the commit messages, a rename of the branch, and a code review. I'll try to get that done tomorrow so that we can start making incremental progress on fixing test failures under 1.9. ---------------------------------------- Bug #2782: Changes in Ruby 1.9.x const_set and const_get prevent puppetd from properly executing https://projects.puppetlabs.com/issues/2782 Author: Al Hoang Status: Ready For Testing Priority: Low Assignee: Markus Roberts Category: unknown Target version: Statler Affected Puppet version: 0.25.1 Keywords: Ruby 1.9 ruby19 Branch: https://github.com/mmrobins/puppet/tree/19_fixes Hello, Attached is a patch with modifications to get puppetd to properly execute when puppetd --trace --verbose --debug is run on the command line. Some changes are: * Explicitly use the top-level File object in lib/puppet/type/file.rb * Add some checks on RUBY_VERSION and avoid called @resource.stat(false) * Call a Ruby 1.8.x compatible version of const_defined? if RUBY_VERSION looks like it is 1.9.x Here are some useful links that might help explain some of the changes to const_set and const_set in Ruby 1.9.x: http://issues.apache.org/jira/browse/BUILDR-140 http://jira.codehaus.org/browse/JRUBY-4197 http://redmine.ruby-lang.org/issues/show/1915 http://markmail.org/message/zr5vh2333yr3k3qi Please note that this assumes that the changes from ticket #2781 are already applied -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
