Jira (PUP-10477) Remove non-local return from agent.rb

[Gheorghe Popescu (Jira)]

Title: Message Title

Gheorghe Popescu updated an issue   Puppet / PUP-10477 Remove non-local return from agent.rb Change By: Gheorghe Popescu Ideally we should never do a non-local return. It was added by mistake in https://github.com/puppetlabs/puppet/commit/ce74cd97085c3d3bd7b4888c80bcbf14ebfdfa2, was made worse in https://github.com/puppetlabs/puppet/commit/10d89dc463ebe8d31cee3a3603e924ae614f754a and a "different but equally wrong" approach was taken in https://github.com/puppetlabs/puppet/commit/42f1f27d914576be95b8745b6015897993f9aea3. It would be great to clean that up so that nil is always returned due to an error, so that [ TODO Puppet::Application::Agent consistently exits with 1.|https://github.com/puppetlabs/puppet/blob/42f1f27d914576be95b8745b6015897993f9aea3/lib/puppet/application/agent.rb#L360-L374 ] Add description Add Comment   This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.357118.1588148530000.49906.1588148640091%40Atlassian.JIRA.