Jira (PUP-10499) Out-of-sync no-op resources should cause dependent resources to skip

[Reid Vandewiele (Jira)]

Title: Message Title

Reid Vandewiele created an issue   Puppet / PUP-10499 Out-of-sync no-op resources should cause dependent resources to skip Issue Type: Improvement Assignee: Unassigned Created: 2020/05/11 12:00 PM Priority: Normal Reporter: Reid Vandewiele Let resource A be a dependency of resource B Let resource A be no-op Problem Puppet will always consider B's dependency to be satisfied, even if resource A is detected to be out-of-sync. Resource A is in no-op mode so it cannot "fail". Puppet will never skip resource B due to a dependency failure. However, resource A is out-of-sync, and is known to be in an incorrect state. Logically, this should cause resource B to be skipped, just as it would be if resource A were to be marked out-of-sync due to a sync failure. Depending on your dependency chains this behavior can cause problems, when Puppet cannot successfully configure resource B unless or until resource A is in-sync. Example Manifest file { 'dependency': path => '/tmp/never-create-me', ensure => present, noop => true, }   notify { 'reliant': message => 'I rely on dependency being in-sync to operate correctly', require => File['dependency'], } Behavior Today Output of puppet apply: Notice: Compiled catalog for reids-macbook-pro.local in environment production in 0.03 seconds Notice: /Stage[main]/Main/File[dependency]/ensure: current_value 'absent', should be 'present' (noop) Notice: I rely on dependency being in-sync to operate correctly Notice: /Stage[main]/Main/Notify[reliant]/message: defined 'message' as 'I rely on dependency being in-sync to operate correctly' Notice: Applied catalog in 0.02 seconds Notice how a dependency of Notify[reliant] is out-of-sync, but Puppet will still attempt to sync Notify[reliant].  Desired Behavior What the output of puppet apply should be: Notice: Compiled catalog for reids-macbook-pro.local in environment production in 0.03 seconds Notice: /Stage[main]/Main/File[dependency]/ensure: current_value 'absent', should be 'present' (noop) Notice: /Stage[main]/Main/Notify[reliant]: Dependency File[dependency] in sync: false Warning: /Stage[main]/Main/Notify[reliant]: Skipping because of out of sync dependencies Considerations While it is desirable to expect that an out-of-sync dependency will cause resources that rely on it to be skipped, this behaviour would need to be feature flagged as it is a different behavior than what we have today. This likely hasn't caused wider confusion mostly because no-op is frequently an all-or-nothing operation; it's less common to no-op some resources and not others, though doing so is highly sought after by many Puppet-as-a-Service customers and is made easier to do using patterns and modules like the popular trlinkin-noop. Maybe something like... resource_dependency_requirement? [main] resource_dependency_requirement = none_failed resource_dependency_requirement = in_sync Add Comment   This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.358347.1589223608000.59168.1589223660065%40Atlassian.JIRA.