Jira (PUP-8897) check_manage_home useradd provider needs to add -M on Debian

[Gabriel Nagy (Jira)]

Title: Message Title

Gabriel Nagy commented on PUP-8897   Re: check_manage_home useradd provider needs to add -M on Debian So, I did some digging on how shadow-utils and libuser implemented the -M flag, and on the assumptions that Puppet made regarding this flag. First, the shadow library implemented the M flag (also known as -no-create-home) back in 2008, in this commit: https://github.com/shadow-maint/shadow/commit/b18d46e68ddf06869bc042297814369e02564c9. For reference, the first tag containing this commit was 4.1.3, which was released on April 15th 2009. Second, RedHat has been maintaining their own patched version of shadow called shadow-utils. What they do is get the upstream shadow source, extensively patch it, then vendor it as shadow-utils, which is present on every RedHat-based OS starting with at least EL 5. Among the patches that RedHat applies is one that adds the same -M functionality as the upstream project did. However, RedHat has been doing this long before that. The oldest SRPM I could find was shadow-utils-4.0.17-12.el5.src.rpm, in which the related patch dates from July 2006. As for the libuser package, the luseradd command seems to have had this option since the beginning of times (see https://pagure.io/libuser/blame/apps/luseradd.c?identifier=1dd9fb1dc8b421e8c1822ba514adabd5eda97f7f#_45, it's inside a suggestive ifdef but we're just going to ignore that for our own sanity). Based on this we can exclude libuser/forcelocal from the discussion, since they always had the flag. Now, the last puzzle piece is the Puppet code itself: def check_manage_home cmd = [] if @resource.managehome? && (!@resource.forcelocal?) cmd << "-m" elsif (!@resource.managehome?) && Facter.value(:osfamily) == 'RedHat' cmd << "-M" end cmd end What we can conclude now is that the -M flag should be added in all cases where managehome is false, but the current code also adds an OS check. Going as far back as git can take us on this, we find the flag added in this commit: https://github.com/puppetlabs/puppet/commit/12452ee9ca294563f2e2724ff36f179004f9846f#diff-f5b9cc80dd02278d845d220721ac0217R32-R33 dated August 14th 2006. Back then it made sense that the only OSes that had -M were RedHat-based, since the upstream shadow project was almost 3 years away from releasing their own version of -M.This also matches what we saw in the RedHat SRPM. The solution here would be to remove the OS check altogether, since most Linux distros have integrated the -M change from shadow. However, this provider is also being used by Solaris, which does not have this flag (obviously). Then there's SLES 11 which we still officially support, and which uses pwdutils instead of shadow for user information management, and which does not have the -M flag. SUSE switched to shadow beginning with SLES 12. So... to make this as future-proof as possible, we should pass -M for everything except Solaris and SLES 11. I think. Add Comment   This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.253150.1527630016000.62492.1589469240031%40Atlassian.JIRA.