Jira (FACT-2724) Confine blocks behave differently with Facter 4, causing spec tests to suddenly fail

[Bogdan Irimie (Jira)]

Title: Message Title

Bogdan Irimie commented on FACT-2724   Re: Confine blocks behave differently with Facter 4, causing spec tests to suddenly fail Nate McCurdy thanks for all the details, they were very useful and allowed us to reproduce the issue. I assume you are using `macOS`, please let me know if this assumption is incorrect. `virtual` fact for `macOS` was not working correctly on `physical` host. Instead of resolving `virtual` fact to `physical`, it was resolving it to `nil`. Because of this issue, your mock allow(Facter.fact(:virtual)).to receive(:value).and_return('physical')| was actually allow(nil).to receive(:value).and_return('physical')| When you added Facter.add(:virtual) you basically created a custom fact and the mock was made on that custom fact instead of `nil`   Please give https://github.com/puppetlabs/facter/pull/2010 a try. It should fix the issue. Add Comment   This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.367390.1595872598000.6898.1596463500207%40Atlassian.JIRA.