Jira (PUP-10628) Performance regression with large hashes using lookup

[Josh Cooper (Jira)]

Title: Message Title

Josh Cooper commented on PUP-10628   Re: Performance regression with large hashes using lookup Tests pass for me locally when Type and TypeSet are removed, so I submitted a PR https://github.com/puppetlabs/puppet/pull/8294. It looks like TypeSet#instance? could be optimized to reject the value if the required pcore_version key is missing, but I'm not sure which keys are actually required based on the way __pcore_init_hash optionally parses the hash: https://github.com/puppetlabs/puppet/blob/main/lib/puppet/pops/types/p_type_set_type.rb#L174-L180. Add Comment   This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.369684.1597848926000.21865.1598052180030%40Atlassian.JIRA.