Issue #6912 has been updated by Ben Hughes. Status changed from Unreviewed to Accepted
Thank you for the steps to repeat! Is this any more harmful than killing puppet as it runs I wonder. Both would leave the run in some unfinished state. Maintaining disable status even if puppet is running is definitely something that should happen. I imagine we could just check the contents of the lockfile before we remove it, to see if it has changed to disabled, even if we don't act on it mid run. ---------------------------------------- Bug #6912: puppetd --disable doesn't disable if run while puppet is executing https://projects.puppetlabs.com/issues/6912 Author: Robert Coli Status: Accepted Priority: Normal Assignee: Category: Target version: Affected Puppet version: 2.6.7 Keywords: Branch: 1) run puppetd -t on a host 2) while 1) is running, do puppetd --disable 3) once 1) completes, run puppetd -t again 4) notice that puppet has not been disabled My understanding of the underlying issue here is that the same lock file is used to indicate "running" and "disabled". It seems somewhat likely that a fix would therefore including a new lock file or other lock mechanism to allow --disable to work predictably. In an environment where puppet runs randomly stqggered, the ability to reliably disable it even if a node happens to be running at that time would be valuable. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
