Jira (PUP-10643) hold => none not idempotent with dpkg provider

Title: Message Title

Gabriel Nagy created an issue

Puppet Version: 6.18.0
Puppet Server Version: n/a
OS Name/Version: Debian/Ubuntu (any)

When explicitly specifying hold => none in a manifest, puppet will always report changes. Sample resource:

package { 'mc':

    ensure => present,

    mark   => none,

Desired Behavior:

Puppet should set mark to none and not report any subsequent changes.

Actual Behavior:

Puppet sets mark to none on each run.

----------------------------

Solved by the following patch:

--- a/lib/puppet/provider/package/dpkg.rb

+++ b/lib/puppet/provider/package/dpkg.rb

@@ -74,7 +74,7 @@ Puppet::Type.type(:package).provide :dpkg, :parent => Puppet::Provider::Package

       elsif ['config-files', 'half-installed', 'unpacked', 'half-configured'].include?(hash[:status])

         hash[:ensure] = :absent

end

-      hash[:mark] = :hold if hash[:desired] == 'hold'

+      hash[:mark] = hash[:desired] == 'hold' ? :hold : :none

     else

       Puppet.debug("Failed to match dpkg-query line #{line.inspect}")

end

This message was sent by Atlassian Jira

--
You received this message because you are subscribed to the Google Groups "Puppet Bugs" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370140.1598357998000.23127.1598358000039%40Atlassian.JIRA.

Reply via email to