Jira (PUP-10650) Remove TypeSetType from RichData

[Josh Cooper (Jira)]

Title: Message Title

Josh Cooper created an issue   Puppet / PUP-10650 Remove TypeSetType from RichData Issue Type: Task Assignee: Unassigned Created: 2020/08/27 4:03 PM Priority: Normal Reporter: Josh Cooper The PTypeSetType class defines a namespace for a set of PCore types. Internally puppet uses PTypeSetType when registering all of the AST model classes. See Puppet::Pops::Mode.register_pcore_types. At one point we considered serializing type information, for example the catalog could contain all of the rich data and the type information needed by the receiver to deserialize. However, the type information was too verbose. So when serializing, we just send the type names, e.g. Sensitive, and assume the receiver knows how to deserialize. Commit 0a195ef6d6 defined RichData as: Variant[Scalar,SemVerRange,Binary,Sensitive,Type,TypeSet,Undef,Hash[RichDataKey,RichData],Array[RichData]] The TypeSet above refers to the PTypeSetType class. The commit also changed the lookup DataProvider to accept all RichData. However, lookup also validates that the data it receives from the data provider contains only RichData. As a result, puppet could perform full type interference on the entire hash. That was optimized in PUP-10628, but it's based on a heuristic, detecting if the pcore_version key exists. There's no reason currently to include TypeSet in RichData, so we should remove that to avoid performance issues. Add Comment   This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.370572.1598569423000.25674.1598569440093%40Atlassian.JIRA.