Jira (PUP-10664) Puppet 6 should log connection error details when a functional puppet master cannot be located

[Josh Cooper (Jira)]

Title: Message Title

Josh Cooper commented on PUP-10664   Re: Puppet 6 should log connection error details when a functional puppet master cannot be located There are two parts to this: 1. The current intended behavior is to not log errors if we eventually find a server to connect to. In other words, only log the exceptions at the error level if we exhaust the server list: $ bx puppet agent -t --server_list localhost:8141,localhost:8140 Info: Using configured environment 'production' Info: Retrieving pluginfacts .. But if you run with debugging you'll see the first failure followed by the second success: $ bx puppet agent -td --server_list localhost:8141,localhost:8140 ... Debug: Resolving service 'puppet' using Puppet::HTTP::Resolver::ServerList Debug: Creating new connection for https://localhost:8141 Debug: Starting connection for https://localhost:8141 Debug: Unable to connect to server from server_list setting: Request to https://localhost:8141/status/v1/simple/master failed after 0.002 seconds: Failed to open TCP connection to localhost:8141 (Connection refused - connect(2) for "localhost" port 8141) Debug: Creating new connection for https://localhost:8140 Debug: Starting connection for https://localhost:8140 Debug: Using TLSv1.2 with cipher DHE-RSA-AES128-GCM-SHA256 Debug: HTTP GET https://localhost:8140/status/v1/simple/master returned 200 OK Debug: Caching connection for https://localhost:8140 Debug: Resolved service 'puppet' to https://localhost:8140/puppet/v3 ... The second part is if the server_list is exhausted, then the code that would normally log the exceptions at error level is bypassed. To confirm the expected behavior, are asking for puppet to log at error level any/all exceptions that occur during server list resolution, even if the resolution is eventually successful for that run? Or should it only log the exceptions if resolution fails? Add Comment   This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.371698.1599857641000.35996.1600130700048%40Atlassian.JIRA.