Issue #6961 has been updated by R.I. Pienaar.
For which version of Puppet does this apply? Puppet is playing a bit loose and fast with what exit codes mean in many cases unfortunately. I know it's changed since I first wrote the provisioner which isnt even that long ago. I think we'll only really have a solid solution here once #4339 has been released, I am likely to park these patches till thats done since that will make this a *lot* better. I'll review these a bit later and cherry pick some of the improvements in skirting aroudn the exit code situation. One quick comment, if you are going to log rotate using logrotate you should tweak the code in lib/mcprovision.rb so it doesnt do its own rotation. ---------------------------------------- Bug #6961: mcollective-server-provisioner not using proper puppet return codes https://projects.puppetlabs.com/issues/6961 Author: Konrad Scherer Status: Unreviewed Priority: Normal Assignee: R.I. Pienaar Category: Target version: Keywords: server-provisioner Branch: Affected mCollective version: The exit codes for puppet are: * 0 - Success, not changed * 1 - Error * 2 - Success, files updated I have also made some small additions * Use fqdn of hostname to do lookup * Add init script for debian * Add logrotate config Changes available here: https://github.com/kscherer/mcollective-server-provisioner Branch: wrs -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
