Jira (PUP-7930) Array delete does not work according to spec when right hand side is hash

[Josh Cooper (Jira)]

Title: Message Title

Josh Cooper commented on PUP-7930   Re: Array delete does not work according to spec when right hand side is hash It is however questionable if it is at all meaningful to treat a hash as a set of key-value tuples that are deleted from the LHS array. I agree that it is questionable and the change is not hard diff --git a/lib/puppet/pops/evaluator/evaluator_impl.rb b/lib/puppet/pops/evaluator/evaluator_impl.rb index 8bf13d22e8..9c03c069d4 100644 --- a/lib/puppet/pops/evaluator/evaluator_impl.rb +++ b/lib/puppet/pops/evaluator/evaluator_impl.rb @@ -1264,7 +1264,6 @@ class EvaluatorImpl when Array y = case y when Array then y - when Hash then y.to_a else [y] end But we have tests that exercise the behavior of deleting hash key tuples from the LHS array, see https://github.com/puppetlabs/puppet/blob/c2b87527385516b64fbe3ef991ea4417df346e9e/spec/unit/pops/evaluator/collections_ops_spec.rb#L64 https://github.com/puppetlabs/puppet/blob/c2b87527385516b64fbe3ef991ea4417df346e9e/spec/unit/pops/evaluator/evaluating_parser_spec.rb#L102 Given that, I'm inclined to update the specification to match the current behavior and add a note warning about the hash to array conversion. Note deleting hashes from the array works provided the RHS is given as an array of hashes for 1 and 2 level hashes: $ bx puppet apply -e "notice([{1 => 2}, {3 => 4}] - [{1 => 2}])" Notice: Scope(Class[main]): [{3 => 4}] .. $ bx puppet apply -e "notice([{1 => {2 => 3}}, {3 => 4}] - [{1 => {2 => 3}}])" Notice: Scope(Class[main]): [{3 => 4}] Add Comment   This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.210105.1505103024000.62892.1603481340135%40Atlassian.JIRA.