Issue #5528 has been updated by Nick Fagerlund.

I worked with Matt on learning and reviewing the UI yesterday, and I'll be 
updating and merging Max's docs shortly. Things:

* I strongly agree with using `certificate_status` as the name of the endpoint, 
because it actually describes (albeit somewhat imperfectly and glibly) the 
thing that we are reading or altering. `ssl_id` and `ssl_client` do not. I can 
go into more detail on this if needed, including its relationship to the other 
SSL REST API endpoints, but the tl;dr is that I no longer have any reservations 
about `certificate_status` as a name. 
* Instinct says we want the ability to filter by state (revoked, request 
pending, signed) when getting the `certificate_statuses` endpoint, but Matt 
convinced me that it's not urgent and this can be done in application logic by 
anything that needs it for now. He'll file a separate feature request. 
* When we do DELETE, it should tell us both what it revoked and what it 
deleted. (Just assume Matt's filing tickets for all these.)
* We found some breakage in the `certificates` endpoint, but I can't remember 
what that was. 
* `certificate_status` isn't returning the same data for both yaml and pson -- 
pson is useful, yaml isn't, right now. 
* The accept header is ignored when deciding what to give you after you do a 
PUT. 

All told, I think this is a workable UI that fits with the rest of our current 
REST API. 
----------------------------------------
Feature #5528: API call to sign, clean or generate certificate request
https://projects.puppetlabs.com/issues/5528

Author: James Turnbull
Status: Accepted
Priority: High
Assignee: 
Category: API
Target version: Statler
Affected Puppet version: 
Keywords: API certificate SSL generate clean sign
Branch: 
https://github.com/MaxMartin/puppet/commits/feature%2Fmaster%2F5528-certificates_signing_api


Proposal from James:

SIGN
<pre>
Certificate Request

PUT /{environment}/certificate_requests/sign/{anything}
PUT /{environment}/certificate_request/sign/{node certificate name}

curl -k -H "Accept: yaml" 
https://puppetmaster:8140/production/certificate_requests/sign/all
curl -k -H "Accept: yaml" 
https://puppetmaster:8140/production/certificate_request/sign/puppetclient
</pre>

CLEAN

<pre>
Certificate Request

PUT /{environment}/certificate_requests/clean/{anything}
PUT /{environment}/certificate_request/clean/{node certificate name}

curl -k -H "Accept: yaml" 
https://puppetmaster:8140/production/certificate_requests/clean/all
curl -k -H "Accept: yaml" 
https://puppetmaster:8140/production/certificate_request/clean/puppetclient
</pre>

GENERATE
<pre>
Certificate Request

GET /{environment}/certificate_request/generate/{node certificate name}

curl -k -H "Accept: yaml" 
https://puppetmaster:8140/production/certificate_request/generate/puppetclient
</pre>


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to