Jira (PUP-10778) User resource is not idempotent on AIX

[Jarret Lavallee (Jira)]

Title: Message Title

Jarret Lavallee created an issue   Puppet / PUP-10778 User resource is not idempotent on AIX Issue Type: Bug Assignee: Unassigned Created: 2020/11/11 8:38 AM Priority: Normal Reporter: Jarret Lavallee Puppet Version: 6.17 Puppet Server Version: 6.12.1 OS Name/Version: AIX 7.2 When using a user resource on AIX and setting the password, the password is updated every agent run. This happens when a user stanza contains a tab in the password line. This is because the regex in https://github.com/puppetlabs/puppet/blob/main/lib/puppet/provider/user/aix.rb#L181 does not account for tabs or multiple spaces. Reproduction: 1. In an AIX 7.2 node add a user resource. user{'testing': ensure => present, password => 'test', } 2. Edit the /etc/security/passwd file to add a tab to the password line. testing: password = test lastupdate = 1605112051 3. Apply the user resource multiple times and confirm that the password it changed b every run. [0] [AIX] root@aix72-9:~ # puppet apply user.pp Notice: Compiled catalog for aix72-9.delivery.puppetlabs.net in environment production in 0.02 seconds Notice: /Stage[main]/Main/User[testing]/password: changed [redacted] to [redacted] Notice: Applied catalog in 0.22 seconds [0] [AIX] root@aix72-9:~ # puppet apply user.pp Notice: Compiled catalog for aix72-9.delivery.puppetlabs.net in environment production in 0.02 seconds Notice: /Stage[main]/Main/User[testing]/password: changed [redacted] to [redacted] Notice: Applied catalog in 0.22 seconds [0] [AIX] root@aix72-9:~ # puppet apply user.pp Notice: Compiled catalog for aix72-9.delivery.puppetlabs.net in environment production in 0.02 seconds Notice: /Stage[main]/Main/User[testing]/password: changed [redacted] to [redacted] Notice: Applied catalog in 0.22 seconds Desired Behavior: The password should be set once unless the password changed. Actual Behavior: The detection of the current password has an incorrect regex and updates the password every agent run. Proposed Fix Change the regex in https://github.com/puppetlabs/puppet/blob/main/lib/puppet/provider/user/aix.rb#L181 to be /password\s+=\s+(\S+)/ Add Comment   This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.377931.1605112736000.76898.1605112740131%40Atlassian.JIRA.