Jira (FACT-2859) [regression] External facts are loaded when using puppet lookup for a different node

[Josh Cooper (Jira)]

Title: Message Title

Josh Cooper created an issue   Facter / FACT-2859 [regression] External facts are loaded when using puppet lookup for a different node Issue Type: Bug Assignee: Unassigned Created: 2020/11/13 3:41 PM Priority: Normal Reporter: Josh Cooper FACT-2666 added a Facter.load_external method which puppet checks to enable/disable external fact loading. The method was added to facter 3, but doesn't exist in facter 4, so puppet doesn't disable external fact loading. # rpm -qa | grep puppet puppet-agent-7.0.0-1.el8.x86_64 # cat /opt/puppetlabs/facter/facts.d/slow.sh #!/bin/sh   >&2 echo "this is slow" # chmod u+x /opt/puppetlabs/facter/facts.d/slow.sh # puppet lookup --node notme key Warning: Facter: Command /opt/puppetlabs/facter/facts.d/slow.sh completed with the following stderr message: this is slow Warning: Facter: Command /opt/puppetlabs/facter/facts.d/slow.sh completed with the following stderr message: this is slow This wasn't noticed in tests, because we don't verify partial doubles: https://github.com/puppetlabs/puppet/blob/29a737f765d94bfb30bdb3d89c55e54edfcc16b9/spec/integration/application/lookup_spec.rb#L101-L102 Add Comment   This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.378374.1605310876000.79467.1605310920084%40Atlassian.JIRA.