Jira (FACT-2869) Puppet 7.0.0 facter changes is_virtual fact to string (from boolean)

[James Ralston (Jira)]

Title: Message Title

James Ralston created an issue   Facter / FACT-2869 Puppet 7.0.0 facter changes is_virtual fact to string (from boolean) Issue Type: Bug Assignee: Unassigned Created: 2020/11/19 9:56 PM Priority: Normal Reporter: James Ralston In Puppet 6.x, facter reports the is_virtual fact as a boolean: $ facter --version; facter --json is_virtual 3.14.14 (commit e36657bea27254f003c8fc71d8ef57454db643e2) { "is_virtual": false } But in Puppet 7.0.0, facter reports the is_virtual fact as a string: $ facter --version; facter --json is_virtual 4.0.46 { "is_virtual": "false" } This is almost certainly a regression, as the 7.0.0 documentation continues to state that the is_virtual fact is a boolean. This is going to cause major breakage for any code that tests is_virtual as a boolean; e.g.: if $facts['is_virtual'] { # do stuff for VMs } else { # do stuff for physical hosts } In the above code, the do stuff for VMs block will always be executed, even for physical hosts, because the boolean evaluation of the String class is true if the length of the string is nonzero and false otherwise, and is_virtual will always have a nonzero length (either "true" or "false"). The easiest work-around for now is to test against the virtual fact instead; e.g.: if $facts['virtual'] != 'physical' { # do stuff for VMs } else { # do stuff for physical hosts } But again, this regression is going to burn people who have any code that tests against is_virtual. Add Comment   This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.378976.1605851800000.83819.1605851820046%40Atlassian.JIRA.