Issue #4880 has been updated by James Turnbull. Target version changed from 1.0.5 to 1.1.0
---------------------------------------- Bug #4880: dashboard is not validating reports it stores https://projects.puppetlabs.com/issues/4880 Author: Peter Meier Status: Closed Priority: Normal Assignee: Nick Lewis Category: Target version: 1.1.0 Keywords: roadmapped Branch: http://github.com/nicklewis/puppet-dashboard/tree/ticket/next/4880 Affected URL: Affected Dashboard version: I was fiddling around with posting stuff to /reports, which lead to the problem that I was able to inject reports into the database which then couldn't be parsed by the dashboard: <pre> ActionView::TemplateError (report was supposed to be a Puppet::Transaction::Report, but was a String) on line #20 of app/views/nodes/_nodes.html.haml: 17: %tr[node]{:class => "#{'active' if node == @node}"} 18: -# %td.check 19: -# = check_box_tag dom_id(node) 20: %td.status{:class => node.status_class} 21: %span{:title => node_title_text(node)} 22: = node_status_icon(node) 23: %td.hostname app/models/report.rb:25:in `report' app/models/report.rb:13:in `failed?' app/models/report.rb:31:in `status' app/models/node.rb:147:in `status_class' [...] </pre> The only way I could get dashboard back running was by spitting out the id's of the failing reports and deleting them manually in the database. It would be nice if either the dashboard is more failsafe against such bad data or that injecting such data (via POST to /reports) isn't possible. Personally, I think the latter is the more safe way. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
