Issue #4816 has been updated by James Turnbull.

Target version deleted (1.0.5)


----------------------------------------
Refactor #4816: Node lookup should be extracted to a helper method
https://projects.puppetlabs.com/issues/4816

Author: Nick Lewis
Status: Accepted
Priority: Low
Assignee: 
Category: 
Target version: 
Keywords: 
Branch: 
Affected URL: 
Affected Dashboard version: 


We currently lookup nodes by ID and then fall back to name, as per #4541. We do 
this in two places:

    @node = Node.find(params[:id]) rescue Node.find_by_name!(params[:id])

and

    node ||= end_of_association_chain.find(params[:id]) rescue nil
    node ||= end_of_association_chain.find_by_name!(params[:id])

These should be combined into a scope or a method on Node.


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to