Jira (FACT-2950) Root of structured core facts cannot be overriden by a custom fact

[Gheorghe Popescu (Jira)]

Title: Message Title

Gheorghe Popescu commented on FACT-2950   Re: Root of structured core facts cannot be overriden by a custom fact This issue is affecting modules unit tests that are running with a Puppet 7 that contains the following change(https://github.com/puppetlabs/puppet/commit/c8cea4478f0810d8f20cbc2148b7ad37029a7e57). An example can be seen on puppetlabs-puppet_agent module: https://github.com/puppetlabs/puppetlabs-puppet_agent/runs/2001456000?check_suite_focus=true This happens because rspec-puppet uses facterdb data to create custom facts in order to stub core system facts. For the `os` fact, it uses the following data: stubbing os with: {"architecture"=>"x64", "family"=>"windows", "hardware"=>"x86_64", "name"=>"windows", "release"=>{"full"=>"2016", "major"=>"2016"}, "windows"=>{"edition_id"=>"ServerStandard", "installation_type"=>"Server", "product_name"=>"Windows Server 2016 Standard", "release_id"=>"1607", "system32"=>"C:\\Windows\\system32"}} This will overwrite only the top `os` fact. If any child fact, like `os.name` is called, that fact will be retrieved from system, resulting in unexpected tests behaviour. Add Comment   This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.389257.1614583384000.153697.1614585120030%40Atlassian.JIRA.