Issue #4732 has been updated by Nigel Kersten.
Daniel Pittman wrote: > Nigel Kersten wrote: > > Sharif Nassar wrote: > > > I'm with R.I. on this one. > > > '*' should be a shell glob, and not some freaky meta-glob. > > > > I'm with both of you. Our user base has clear expectations around > > globbing. If we import too much with this syntax and break something, > > people will understand and modify their glob. > > ...and much as I like consistency, this fills me with dread: all of a sudden > my `init.pp~` will be imported along with `init.pp`, causing all sorts of > failures to pop up, and much gnashing of teeth and reconfiguring of editors. > I don't think that most sysadmins will be surprised by the idea that the > puppet language uses different rules - I certainly always thought of this as > being an import of the "class" namespace, not files on disk. > > (Actually, I am vaguely surprised that you can actually specify a full path > on disk to import, which means you can pull in things outside the regular > paths, so perhaps my perspective is informed by that misinformation...) Yeah, import has nothing to do with classes. That's one of the reasons why it's evil and I push everyone towards include instead. It's filesystem paths, and in those cases it makes total sense for the glob to act just like the shell glob. ---------------------------------------- Bug #4732: Use of .pp/.rb extention to sniff file type breaks "everything is pp" assumption https://projects.puppetlabs.com/issues/4732 Author: Markus Roberts Status: Accepted Priority: Normal Assignee: Category: Target version: Statler Affected Puppet version: 2.6.1 Keywords: Branch: R.I. writes: This fix breaks/improves import so that it will now only import files named .pp or .rb where in the past it would happily have imported anything matching the supplied glob: <pre> import "/etc/puppet/manifests/nodes/*" </pre> This now only imports .pp and .rb not * as it’s asked to do. -- You have received this notification because you have either subscribed to it, or are involved in it. To change your notification preferences, please click here: http://projects.puppetlabs.com/my/account -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/puppet-bugs?hl=en.
