Jira (FACT-2953) os codename should use parent os codename

[Corey Osman (Jira)]

Title: Message Title

Corey Osman created an issue   Facter / FACT-2953 os codename should use parent os codename Issue Type: Bug Affects Versions: FACT 3.y, FACT 4.y Assignee: Unassigned Created: 2021/03/02 6:49 PM Priority: Normal Reporter: Corey Osman I am using some lesser known distro derivatives of ubuntu and running into issues with how some of the core facts parse os information. Several modules don’t work when puppet installs packages since the distro codename is used instead of the upstream codename.  As an example the docker and puppet-agent fail to download packages because those modules rely on the apt module which configures an apt source with a codename that is only useful for the distro maintainer.   I think we should be referencing UBUNTU_CODENAME instead if available.     # created by the apt module (pisces is distro codename) deb https://pe-std.puppet.vm:8140/packages/2019.8.5/ubuntu-18.04-amd64 pisces puppet6   # https://github.com/puppetlabs/puppetlabs-apt/blob/main/manifests/source.pp#L76   miner@4ccca5[192.168.2.18]~ more /etc/os-release NAME="Ubuntu" VERSION="18.04.5 LTS (Bionic Beaver)" ID=ubuntu ID_LIKE=debian PRETTY_NAME="Ubuntu 18.04.5 LTS" VERSION_ID="18.04" HOME_URL="https://www.ubuntu.com/" SUPPORT_URL="https://help.ubuntu.com/" BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/" PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy" VERSION_CODENAME=bionic UBUNTU_CODENAME=bionic     miner@4ccca5[192.168.2.18]~ more /etc/lsb-release DISTRIB_ID=MMP DISTRIB_RELEASE=2.8.20 DISTRIB_CODENAME=pisces DISTRIB_VARIANT=stable DISTRIB_OPENCL=default DISTRIB_DESCRIPTION="MMP 2.8.20 stable" This ends up creating errors during package installation because the apt source is pointing to a package that does not exist and never will.       Error: Could not update: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold --force-yes install puppet-agent=6.21.1-1pisces' returned 100: Reading package lists... Building dependency tree... Reading state information... W: --force-yes is deprecated, use one of the options starting with --allow instead. E: Version '6.21.1-1pisces' for 'puppet-agent' was not found Error: /Stage[main]/Puppet_agent::Install/Package[puppet-agent]/ensure: change from '6.21.1-1bionic' to '6.21.1-1pisces' failed: Could not update: Execution of '/usr/bin/apt-get -q -y -o DPkg::Options::=--force-confold --force-yes install puppet-agent=6.21.1-1pisces' returned 100: Reading package lists... Building dependency tree... Reading state information... W: --force-yes is deprecated, use one of the options starting with --allow instead. E: Version '6.21.1-1pisces' for 'puppet-agent' was not found   This of course fails puppet and the node is unable to run. The problem is facter is deriving the codename from the lsb-release file which should be reserved for lsbdistro facts only and not merged into the os.distro fact.  The codename should be bionic IMHO since that is what is found in /etc/os-release.    This OS is a specialized distro for crypto mining purposes and there are dozens others just like it. I do not think making one off exceptions for all them is feasible. Instead supporting this pattern is a better approach when there is a upstream distro that it follows.  LinuxMint is the same way, but facter already has exceptions I believe.     1:>> $os => { "architecture" => "amd64", "distro" => { "codename" => "pisces", "description" => "MMP 2.8.20 stable", "id" => "MMP", "release" => { "full" => "2.8.20", "major" => "2.8", "minor" => "20" } }, "family" => "Debian", "hardware" => "x86_64", "name" => "Ubuntu", "release" => { "full" => "18.04", "major" => "18.04" }, "selinux" => { "enabled" => false } }   3:>> $::lsbdistcodename => "pisces" 4:>> $::lsbdistdescription => "MMP 2.8.20 stable" 5:>> $::lsbdistid => "MMP" 6:>> $::lsbdistrelease => "2.8.20" 7:>> $::lsbmajdistrelease => "2.8" 8:>> $::lsbminordistrelease => "20"   I have not confirmed facter 4 has this issue, but facter 3 does. The workaround for me is ini_setting{'DISTRIB_CODENAME': ensure => present, path => '/etc/lsb-release', value => 'bionic', setting => 'DISTRIB_CODENAME', before => Stage[main] } Add Comment   This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.389690.1614739764000.155755.1614739800057%40Atlassian.JIRA.