Issue #7018 has been updated by Ben Hughes.

Commit, to save time:

<pre>
Subject: [Puppet-dev] [PATCH/puppet 1/1] (#7018) explain internals better in
        service provider documentation

Add explicit reasoning for hasstatus in the documentation with certain
"virtual" services.

Just to clear up why notify => Service["something_virtual"] requires
hasstatus defining for it to function.

Signed-off-by: Ben Hughes <[email protected]>
---
 lib/puppet/type/service.rb |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/lib/puppet/type/service.rb b/lib/puppet/type/service.rb
index 0d09c3d..8387dd5 100644
--- a/lib/puppet/type/service.rb
+++ b/lib/puppet/type/service.rb
@@ -97,7 +97,10 @@ module Puppet
         `status` parameter).

         If you do not specify anything, then the service name will be
-        looked for in the process table."
+        looked for in the process table. Be aware that 'virtual' init
+        scripts such as networking, that don't have something in the
+        process table need this functionality to be used with
+        notify/require trigger actions."

       newvalues(:true, :false)
     end
--
1.7.4.2
</pre>
----------------------------------------
Bug #7018: Explain internals better in service provider documentation
https://projects.puppetlabs.com/issues/7018

Author: Ben Hughes
Status: Ready For Testing
Priority: Normal
Assignee: Ben Hughes
Category: documentation
Target version: 
Affected Puppet version: 
Keywords: service
Branch: 
https://github.com/barn/puppet/tree/ticket%2F2.6.x%2F7018-explain_internals_better_in_service_provider_documentation


The documentation could be clearer for quite what service does with regards to 
hasstatus and subscriptions/notfiy

<pre>
AUTOFS without HASSTATUS (not restarted even though its running)
debug: Service[autofs](provider=redhat): Executing 'ps -ef'
debug: Puppet::Type::Service::ProviderRedhat: Executing '/sbin/chkconfig 
autofs' 
debug: Service[autofs](provider=redhat): Executing '/sbin/service autofs start'
debug: Puppet::Type::Service::ProviderRedhat: Executing '/sbin/chkconfig autofs'
notice: /Stage[main]/mypuppet_autofs/Service[autofs]/ensure: ensure changed 
'stopped' to 'running'
debug: Service[autofs](provider=redhat): Executing 'ps -ef'
debug: /Stage[main]/mypuppet_autofs/Service[autofs]: Skipping restart; service 
is not running

AUTOFS with HASSTATUS: debug: Service[autofs](provider=redhat): Executing 
'/sbin/service autofs status' 
debug: Puppet::Type::Service::ProviderRedhat: Executing '/sbin/chkconfig 
autofs' debug: Service[autofs](provider=redhat): Executing '/sbin/service 
autofs status'  debug: Service[autofs](provider=redhat): Executing 
'/sbin/service autofs restart'

NETWORK without HASSTATUS (not restarting) 
debug: Service[network](provider=redhat): Executing 'ps -ef' 
debug: /Stage[main]/mypuppet_bonding/Service[network]: Skipping restart; 
service is not running

NETWORK with HASSSTATUS 
debug: Service[network](provider=redhat): Executing '/sbin/service network 
status' 
debug: Service[network](provider=redhat): Executing '/sbin/service network 
status' 
debug: Service[network](provider=redhat): Executing '/sbin/service network 
stop' 
debug: Service[network](provider=redhat): Executing '/sbin/service network 
start'
</pre>


-- 
You have received this notification because you have either subscribed to it, 
or are involved in it.
To change your notification preferences, please click here: 
http://projects.puppetlabs.com/my/account

-- 
You received this message because you are subscribed to the Google Groups 
"Puppet Bugs" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/puppet-bugs?hl=en.

Reply via email to