Jira (PUP-10967) Puppet always prints errors in debug when trying to resolve account to SID

[Josh Cooper (Jira)]

Title: Message Title

Josh Cooper created an issue   Puppet / PUP-10967 Puppet always prints errors in debug when trying to resolve account to SID Issue Type: Bug Affects Versions: PUP 7.5.0 Assignee: Unassigned Created: 2021/03/16 6:16 PM Priority: Minor Reporter: Josh Cooper Puppet on Windows shows the following errors when running with debugging: C:\> puppet agent -t --debug ... Debug: Processing report from xxx with processor Puppet::Reports::Store Debug: Could not retrieve raw SID bytes from 'Administrator': Failed to convert string SID: Administrator: The security ID structure is invalid. Debug: Could not retrieve raw SID bytes from 'Administrator': Failed to convert string SID: Administrator: The security ID structure is invalid. This debugging was added in https://github.com/puppetlabs/puppet/commit/bea9ff75d5946dbb92c90ef068cf6c2d4cb0db85. However, the name_to_principal method is sometimes called with valid account names like Administrator, so the call to string_to_sid_ptr fails with (ERROR_INVALID_SID 0x539 and the debug message is printed. I think it'd be better to check if name starts with something like S-\d+-\d+ or only log the error if e.code != 0x539. For example, if the SID string refers to an account that doesn't exist, you'll get 0x534 ERROR_NONE_MAPPED. Add Comment   This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.391432.1615943783000.168013.1615943820048%40Atlassian.JIRA.