Jira (PUP-11000) Race condition with agent_disabled_lockfile

[George Campbell (Jira)]

Title: Message Title

George Campbell updated an issue   Puppet / PUP-11000 Race condition with agent_disabled_lockfile Change By: George Campbell *Puppet Version: Affects all versions* *Puppet Server Version:* *OS Name/Version: CentOS 7* This is essentially the same issue as seen in a an old PR which was lost over the years -   [https://github.com/puppetlabs/puppet/pull/1158] where rapid or parallel puppet runs can cause an already existing {{agent_disabled_lockfile}} to get truncated  *Desired Behavior:* I do not believe puppet actually needs to be creating a resource for this file, the {{agent_catalog_run_lockfile}} has a setting type of {{string}} for this reason ([https://github.com/puppetlabs/puppet/blob/main/lib/puppet/defaults.rb#L1669]) I'd like to apply the same setting type to {{agent_disabled_lockfile}} *Actual Behavior:* Examples: {{puppet agent --test --trace --debug --logdest /root/puppet-debug.log}} Lockfile being created (grep agent_disabled puppet-debug.log): Note: {{File[/opt/puppetlabs/puppet/cache/state/agent_disabled.lock]/ensure (debug): created}} {code:java}2021-03-31 10:49:33 +0000 Puppet (debug): Using settings: adding file resource 'agent_disabled_lockfile': 'File[/opt/puppetlabs/puppet/cache/state/agent_disabled.lock]{:path=>"/opt/puppetlabs/puppet/cache/state/agent_disabled.lock", :ensure=>:file, :loglevel=>:debug, :links=>:follow, :backup=>false}' 2021-03-31 10:49:34 +0000 /File[/opt/puppetlabs/puppet/cache/state/agent_disabled.lock]/seluser (debug): Found seluser default 'system_u' for /opt/puppetlabs/puppet/cache/state/agent_disabled.lock 2021-03-31 10:49:34 +0000 /File[/opt/puppetlabs/puppet/cache/state/agent_disabled.lock]/selrole (debug): Found selrole default 'object_r' for /opt/puppetlabs/puppet/cache/state/agent_disabled.lock 2021-03-31 10:49:34 +0000 /File[/opt/puppetlabs/puppet/cache/state/agent_disabled.lock]/seltype (debug): Found seltype default 'usr_t' for /opt/puppetlabs/puppet/cache/state/agent_disabled.lock 2021-03-31 10:49:34 +0000 /File[/opt/puppetlabs/puppet/cache/state/agent_disabled.lock]/selrange (debug): Found selrange default 's0' for /opt/puppetlabs/puppet/cache/state/agent_disabled.lock 2021-03-31 10:49:34 +0000 /File[/opt/puppetlabs/puppet/cache/state/agent_disabled.lock] (debug): Adding autorequire relationship with File[/opt/puppetlabs/puppet/cache/state] 2021-03-31 10:49:34 +0000 /File[/opt/puppetlabs/puppet/cache/state/agent_disabled.lock]/ensure (debug): created {code}  Strace from guilty {{puppet agent --test}} {code:java}428070 10:49:34.313537 open("/opt/puppetlabs/puppet/cache/state/agent_disabled.lock", O_WRONLY|O_CREAT|O_TRUNC|O_CLOEXEC, 0666) = 18</opt/puppetlabs/puppet/cache/state/agent_disabled.lock> <0.000076> {code} Add Comment   This message was sent by Atlassian Jira (v8.5.2#805002-sha1:a66f935) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.393433.1617190078000.178317.1617190860073%40Atlassian.JIRA.