Jira (FACT-3006) Centralize and document fact matching and filtering

[Gabriel Nagy (Jira)]

Title: Message Title

Gabriel Nagy created an issue   Facter / FACT-3006 Centralize and document fact matching and filtering Issue Type: Improvement Assignee: Unassigned Created: 2021/04/12 4:02 AM Labels: tech-debt Priority: Normal Reporter: Gabriel Nagy Throughout FACT-2998 we improved fact querying/matching/filtering but currently the functionality (attempting to dig in the facts) is spread out in at least 2 places: FactAugmenter and FactFilter. We should unify all these functionalities in a single class, preferably inside the FactFilter class. Also, even if it's private API we should document the purpose and boundaries of the FactFilter class, preferably also the other classes (Augmenter, QueryParser...). FactFilter: https://github.com/puppetlabs/facter/blob/0c769fff1e70f0673db90841f305aacd190878cb/lib/facter/framework/core/fact_filter.rb#L8 FactAugmenter: https://github.com/puppetlabs/facter/blob/0ac50a34ec0ec079413b2f1329085b490821d667/lib/facter/framework/core/fact_augmenter.rb#L36 FactCollection (mentioning this because it also relies on the dig..rescue pattern): https://github.com/puppetlabs/facter/blob/0ac50a34ec0ec079413b2f1329085b490821d667/lib/facter/models/fact_collection.rb#L24 Add Comment   This message was sent by Atlassian Jira (v8.13.2#813002-sha1:c495a97) -- You received this message because you are subscribed to the Google Groups "Puppet Bugs" group. To unsubscribe from this group and stop receiving emails from it, send an email to puppet-bugs+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/puppet-bugs/JIRA.394894.1618225336000.6027.1618225380055%40Atlassian.JIRA.